Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify MAX32625 targets #327

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

multiplemonomials
Copy link
Collaborator

@multiplemonomials multiplemonomials commented Aug 22, 2024

Summary of changes

I noticed while working on #326 that there was a weird setup going on with the MAX32625 targets, where there were two CMake targets for the "boot" (with bootloader) and "no boot" (no bootloader, uses full memory area) versions. Their linker scripts are identical except different values for MBED_APP_START and MBED_APP_SIZE. This is a classic situation where the new memory bank config system can help make things simpler and remove duplicate linker scripts! I removed the boot/no boot stuff and just had one of the targets configure the memory bank size.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Unfortunately I do not have a board to test with, but I did verify that this change compiles.


Base automatically changed from dev/memory-bank-information to master September 13, 2024 03:35
@multiplemonomials multiplemonomials force-pushed the dev/unify-max32625-targets branch from f30f1c3 to 8bf7db2 Compare September 13, 2024 03:36
@multiplemonomials multiplemonomials merged commit 40e3056 into master Sep 13, 2024
10 checks passed
@multiplemonomials multiplemonomials deleted the dev/unify-max32625-targets branch September 13, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants